refactor(gogoanime): Refactor fetchEpisodeSources #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riimuru
reviewed
Apr 8, 2024
src/providers/anime/gogoanime.ts
Outdated
| @@ -476,7 +476,7 @@ class Gogoanime extends AnimeParser { | |||
| throw new Error('Something went wrong. Please try again later.'); | |||
| } | |||
| }; | |||
| fetchDirectDownloadLink = async (downloadUrl: string, captchaToken: string?): Promise<{ source: string | undefined; link: string | undefined }[]> => { | |||
| fetchDirectDownloadLink = async (downloadUrl: string, captchaToken: string): Promise<{ source: string | undefined; link: string | undefined }[]> => { | |||
There was a problem hiding this comment.
@hase0278 after removing the null safety on captchaToken the if statement on line 485 doesn't seem to be needed anymore
There was a problem hiding this comment.
Okay I can edit it if needed. Just been busy lately.
|
I'm not sure if that's always the case with gogoanime download domain, but this is a good approach in case they change domains. |
riimuru
reviewed
Apr 8, 2024
riimuru
approved these changes
Apr 16, 2024
This was referenced Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactoring fetch episode sources for slightly faster direct download link generator. Basically just made sure to make download link point to updated domain since referer hostname = download hostname? Or is it not always the case? Because if it is not always the case please reject this PR.