This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
MOB-5721 fix date pattern for QueryDate, hh --> HH #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccocco-eig
approved these changes
Jun 5, 2018
ccocco-eig
approved these changes
Jun 5, 2018
ggrell
reviewed
Jun 7, 2018
| @@ -29,7 +29,7 @@ | |||
| * The converter factory used for Jackson JSON conversion | |||
| */ | |||
| public class JacksonConverterFactory extends Converter.Factory { | |||
| public final static String ISO_8601_DATE_PATTERN = "yyyy-MM-dd'T'hh:mm:ss.SS'Z'"; | |||
| public final static String ISO_8601_DATE_PATTERN = "yyyy-MM-dd'T'HH:mm:ss.SS'Z'"; | |||
There was a problem hiding this comment.
Yes, thank you, this is correct now!
ggrell
reviewed
Jun 7, 2018
|
|
||
| @Test | ||
| public void test24HourDateConversions() { | ||
| ZonedDateTime date = ZonedDateTime.parse("2018-06-04T09:07:30-04:00"); |
There was a problem hiding this comment.
I think this needs the "Z" at the end ("2018-06-04T09:07:30-04:00Z") to match the ISO-8601 format that AppConnect uses.
ggrell
suggested changes
Jun 7, 2018
ggrell
approved these changes
Jun 11, 2018
|
@ggrell Once this is released, I will modify toolkit and listbuilder to point to 5.2.2. |
ggrell
approved these changes
Jun 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROBLEM
The date String pattern used by the QueryDate class did not support 24 hr time, and would produce incorrect date strings when used in service queries
SOLUTION
Modified the string pattern hours from hh to HH
TESTING
A new unit test has been added to test that 24 hour time is supported in QueryDateTests.java