feat(TextField): add wheel event handler for input[type="number"] #3820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Добавил патч на слушатель события `wheel`. Добавил тесты.
gizeasy
requested changes
Nov 19, 2024
| inputRef.current?.blur(); | ||
| } else if (type === 'number' && onChange) { | ||
| const { value } = e.target as HTMLInputElement; | ||
|
|
There was a problem hiding this comment.
Тут необходимо учитывать брать значение шага из getValueByStep, так как шаг можно указать массивом произвольных чисел.
Я в канари компоненте начну сейчас реализацию если что сюда могу перенести, задачка у меня в спринте уже была.
There was a problem hiding this comment.
Так здесь же по идее эту задачу браузер возьмет на себя, и в поле value будет значение с учетом шага
There was a problem hiding this comment.
Да, но можно в step закинуть массив к примеру [0,15,25,70] и тогда нужно чтобы инпут переходил от шага к шагу.
Добавил обработчик по умолчанию для события `wheel`. Покрыл тестами.
gizeasy
force-pushed
the
feat/text-field-type-number-wheel
branch
from
9ca8d4e to
168be9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание изменений
Закрывает #3767. Добавил патч на слушатель события
wheel. Добавил тесты.Чек-лист
Опционально