-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TaskLib, PSR-3 logger, and interim DI container. #283
Conversation
…er, and a PSR-3 logger based on Consolidation\Log.
… us to reduce internal coupling, and also support temporary and simulated tasks in a uniform way.
Regarding which DI Container to use, see How to Configure Monolog to Display Console Messages as an example. We want to start doing some bridging with existing code based on Symfony Console, so we'll want to make it easy to do things like I further improved the decoupling of the code in #284; although there are still a couple of backwards-compatibility-breaking changes needed to fully separate tasks and all task implementations from the DI container and Config class, that PR and this one gets Robo really close. If the changes here & there are okay, next steps are largely dependent on what we want to do vis-a-vis versioning and backwards compatibility. |
…look more like the original API.
…the function name and the service name. Service class name may vary.
…eprecation warning if an unconfigured task attempts to print anything.
… multiple providers may be registered.
Task assembly
looks like this PR can be closed now, right? |
This code should have been merged into master when you merged task-assembly, since I branched that PR off of this one. I may have rebased in the middle, confusing GitHub. I'll confirm the state of master and close here. |
This has been merged. |
Split off TaskLib from Robo\Tasks. Add a Dependency Injection container, and a PSR-3 logger based on Consolidation\Log.
Continuation of #273. Squashed and rebased with master.