ci: update job name to include install constraints (test old versions)

consideRatio · Apr 2, 2024 · 36bf01e · 36bf01e
1 parent 2d9d226
commit 36bf01e
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -62,7 +62,7 @@ jobs:
           path: ./dist
 
   test:
-    name: ${{ matrix.os }} ${{ matrix.python-version }} ${{ matrix.pip-extras }}
+    name: ${{ matrix.os }} ${{ matrix.python-version }} ${{ matrix.pip-extras }} ${{ (matrix.pip-install-constraints != '') && '(oldest deps)') || '' }}
     needs: [build]
     timeout-minutes: 30
     runs-on: ${{ matrix.os }}
@@ -99,11 +99,16 @@ jobs:
           - os: ubuntu-22.04
             python-version: "3.8"
             pip-extras: classic
+            # jupyter-client and jupyter-core are transient dependencies for
+            # jupyter-server that we have to pin to avoid issues installing
+            # tornado as old as 5.1
             pip-install-constraints: >-
               jupyter-server==1.0
               simpervisor==1.0
               tornado==5.1
               traitlets==4.2.1
+              jupyter-client==7.2.0
+              jupyter-core==4.9.2
 
           # Workaround for excluded 3.12 test mentioned in a FIXME above
           - os: ubuntu-22.04
@@ -182,7 +187,7 @@ jobs:
         uses: actions/upload-artifact@v4
         with:
           name: |-
-            tests-${{ matrix.os }}-${{ matrix.python-version }}-${{ matrix.pip-extras }}-${{ github.run_attempt }}
+            tests-${{ matrix.os }}-${{ matrix.python-version }}-${{ matrix.pip-extras }}-${{ (matrix.pip-install-constraints != '') && 'oldest-') || '' }}${{ github.run_attempt }}
           path: |
             ./build/pytest
             ./build/coverage