This repository has been archived by the owner on Dec 20, 2023. It is now read-only.
Refactor subnet ID and infer ChainID from SubnetID #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: consensus-shipyard/go-ipc-types#21 consensus-shipyard/ipc-actors#109
Fixes: #178
This PR:
SubnetIDrefactor, and upgrades thego-ipc-typeswith the corresponding changes.ChainIDof the network from itsSubnetIDinstead of inheriting it from the build parameter, ensuring that every child subnet has a different chainID dependent of their unique ID.This change required changing things all over the place (thus the large amount of files changed). Even if tests pass, I highly recommend doing an end-to-end test from the IPC agent and testing the deployment of the infra scripts before merging this PR (and the dependent ones).