This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
IPC-304: add permissioned flag for new contract version #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejwitowski
approved these changes
Dec 5, 2023
| @@ -96,4 +97,9 @@ pub struct CreateSubnetArgs { | |||
| help = "Minimum fee for cross-net messages in subnet (in whole FIL)" | |||
| )] | |||
| pub min_cross_msg_fee: f64, | |||
| #[arg( | |||
| long, | |||
There was a problem hiding this comment.
the conversion to long will be done automatically by the CLI library we use, right?
There was a problem hiding this comment.
This long what specifies is that the cli will only expect the long form of the flag name i.e. --permissioned not the short version which would be -p.
| long, | ||
| help = "Deploy static network where validators can't join in a permissionless manner" | ||
| )] | ||
| pub permissioned: bool, |
There was a problem hiding this comment.
Should where be a default value false/0 or do you want devs to explicitly decide it? (if so we'd need to update create subnet flows in docs too)
There was a problem hiding this comment.
The default value for bool flags is already false. It will only be set to true if someone passes explicitly the flag.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: consensus-shipyard/ipc-solidity-actors#305
Upgrades contract version and introduces a
permissionedflag to address https://github.com/consensus-shipyard/ipc-solidity-actors/issue/304