This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
Support top down query #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlrocha
suggested changes
Oct 5, 2023
ipc/provider/src/lib.rs
Outdated
| conn.manager().chain_head_height().await | ||
| } | ||
|
|
||
| pub async fn get_genesis_epoch(&self, subnet: &SubnetID) -> anyhow::Result<ChainEpoch> { |
There was a problem hiding this comment.
Is this a duplicate of the genesis_epoch above?
ipc/provider/src/lib.rs
Outdated
| Some(conn) => conn, | ||
| }; | ||
|
|
||
| conn.manager().chain_head_height().await |
There was a problem hiding this comment.
Also, this doesn't seem what you want to do, right? :)
There was a problem hiding this comment.
right, this method should be removed.
| }; | ||
|
|
||
| conn.manager() | ||
| .get_validator_changeset(subnet, start, end) |
There was a problem hiding this comment.
Where is this one implemented?
There was a problem hiding this comment.
In the evm manager instance.
ipc/provider/src/manager/subnet.rs
Outdated
| @@ -128,6 +128,8 @@ pub trait SubnetManager: Send + Sync + TopDownCheckpointQuery { | |||
| /// Trait to interact with a subnet to query the necessary information for top down checkpoint. | |||
| #[async_trait] | |||
| pub trait TopDownCheckpointQuery: Send + Sync { | |||
| /// Returns the chain head height | |||
There was a problem hiding this comment.
This comment is wrong, right?
| @@ -572,6 +598,25 @@ impl IpcProvider { | |||
|
|
|||
| conn.manager().get_chain_id().await | |||
| } | |||
|
|
|||
| pub async fn get_chain_head_height(&self, subnet: &SubnetID) -> anyhow::Result<ChainEpoch> { | |||
| let conn = match self.connection(subnet) { | |||
There was a problem hiding this comment.
Isn't the change set picked up from the parent?
There was a problem hiding this comment.
this is get chain head height? Anyways, for change set, it's from the subnet actor in parent, so the address should be derived from the subnet directly.
adlrocha
approved these changes
Oct 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more top down finality util queries in provider.