This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
adlrocha
approved these changes
Feb 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's get a 👍 from @hmoniz that he is OK with this approach too and let's get it merged.
aakoshh
reviewed
Feb 23, 2023
aakoshh
reviewed
Feb 23, 2023
hmoniz
approved these changes
Feb 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Assuming you'll address Akosh's comments.
Co-authored-by: Akosh Farkash <[email protected]>
…pc-client into convert_to_lib
cryptoAtwill
commented
Feb 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To migrate
main.rs
to use bothmain.rs
andlib.rs
, reasons are as following:main.rs
, but it's empty and it leads to a lot of clippy dead code warning. Moving tolib.rs
will resolve these warnings.SubnetManager
, it needs to import modules fromipc-agent
, hence it's only possible if we change to lib.cargo test
does not trigger the doc tests, withlib
it's just easy.Since there is the chance, I also fixed a few clippy warning, so that we are now warning free!