Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

refactor subnet ID and chain ID infered from subnet ID #217

Merged
merged 7 commits into from
Jun 7, 2023

Conversation

adlrocha
Copy link
Contributor

@adlrocha adlrocha commented Jun 5, 2023

Depends on https://github.com/consensus-shipyard/go-ipc-types/pull/187 consensus-shipyard/go-ipc-types#21 consensus-shipyard/ipc-actors#109
Fixes: https://github.com/consensus-shipyard/ipc-agent/pull/214

This PR:

  • Integrates the new changes over SubnetID where the ChainID determines the root ID for the subnet.
  • Returns the robust address when creating a new subnet.

Work pending

  • Before merging this PR (and the dependent ones) we should do a dry-run through all of the tutorials of the IPC agent to ensure that the changes work and updating accordingly the instructions.

@adlrocha adlrocha requested a review from cryptoAtwill June 5, 2023 08:10
adlrocha added 2 commits June 7, 2023 20:34
* fix itests for new subnetID and some improvements

* address comments

* upgrade chain-id computation
@adlrocha adlrocha changed the base branch from main to dev June 7, 2023 18:39
@adlrocha adlrocha merged commit 47f6be1 into dev Jun 7, 2023
@adlrocha adlrocha deleted the adlrocha/subnetid-refactor branch June 7, 2023 18:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use robust address instead of ID address for subnet IDs
2 participants