Include gateway addr in subnet config #137
Conversation
There was a problem hiding this comment.
A few minor comments (they are non-blocking, so feel free to disregard them if you don't feel they apply right now).
And the reason for the request for changes. IIRC we were using DEFAULT_GATEWAY_ADDR all over the place whenver there was a request that required the gateway as an argument. I don´t see that changed in the code, did I miss it or should we change that also before we merge and pick up the gateway address from the config.
| jsonrpc_api_http = "https://example.org/rpc/v0" | ||
| jsonrpc_api_ws = "wss://example.org/rpc/v0" | ||
| auth_token = "YOUR ROOT AUTH TOKEN" | ||
|
|
||
| [subnets.child] | ||
| [[subnets]] |
There was a problem hiding this comment.
From total ignorance, would it be possible to make the config something like so that we use the id already as the key of the map?:
[subnets]
[[/root]]
....
[[/root/t01011]]
There was a problem hiding this comment.
This one I'm not so sure, but I think it cannot be done, because [[/root]] would translate to hashmap of "/root" as key and whatever in the ... as an array of deserialized struct. But I think we should avoid using subnet id string because of /, everytime we have to escape it with ", which is easy to make mistake.
config/template.toml
Outdated
| id = "/root" | ||
| network_name = "root" | ||
| gateway_addr = 64 |
There was a problem hiding this comment.
Out of a curiosity, why did you use a u64 instead of an Address here? I can think of a few reasons why we may want to do this, but I don´t know if it would be the best approach for users. @hmoniz, thoughts?
There was a problem hiding this comment.
perhaps, it's just convenience I guess. Convert actor id to address is quite straightforward. If we want to use string, it works too.
There was a problem hiding this comment.
Let's either use gateway_addr = "t064" or let's call this field gateway_id and make it an uint. Whatever works best for you.
There was a problem hiding this comment.
use the first option, please check
…ipc-client into refactor_config
…into refactor_config
The changes in this PR:
Hashmap<String, Subnet>toHashmap<SubnetID, Subnet>, so that all the look ups we can directly use subnet id instead of converting to string.