update review

ipc/cli/src/commands/subnet/create.rs

@@ -13,6 +13,8 @@ use std::str::FromStr;
 use crate::commands::get_ipc_provider;
 use crate::{f64_to_token_amount, CommandLineHandler, GlobalArguments};
 
+const DEFAULT_ACTIVE_VALIDATORS: u16 = 100;
+
 /// The command to create a new subnet actor.
 pub struct CreateSubnet;
 
@@ -36,7 +38,7 @@ impl CreateSubnet {
                 arguments.min_validators,
                 f64_to_token_amount(arguments.min_validator_stake)?,
                 arguments.bottomup_check_period,
-                arguments.active_validators_limit,
+                arguments.active_validators_limit.unwrap_or(DEFAULT_ACTIVE_VALIDATORS),
             )
             .await?;
 
@@ -79,5 +81,5 @@ pub struct CreateSubnetArgs {
     #[arg(long, help = "The bottom up checkpoint period in number of blocks")]
     pub bottomup_check_period: ChainEpoch,
     #[arg(long, help = "The max number of active validators in subnet")]
-    pub active_validators_limit: u16,
+    pub active_validators_limit: Option<u16>,
 }

ipc/cli/src/commands/subnet/join.rs

@@ -27,14 +27,13 @@ impl CommandLineHandler for JoinSubnet {
             Some(address) => Some(Address::from_str(address)?),
             None => None,
         };
-        let metadata =
-            base64::engine::general_purpose::STANDARD_NO_PAD.decode(&arguments.metadata)?;
+        let public_key = hex::decode(&arguments.public_key)?;
         provider
             .join_subnet(
                 subnet,
                 from,
                 f64_to_token_amount(arguments.collateral)?,
-                metadata,
+                public_key,
             )
             .await
     }
@@ -53,6 +52,6 @@ pub struct JoinSubnetArgs {
         help = "The collateral to stake in the subnet (in whole FIL units)"
     )]
     pub collateral: f64,
-    #[arg(long, short, help = "The validator's metadata, base64 encoded")]
-    pub metadata: String,
+    #[arg(long, short, help = "The validator's metadata, hex encoded")]
+    pub public_key: String,
 }

ipc/provider/src/lib.rs

@@ -262,7 +262,7 @@ impl IpcProvider {
         subnet: SubnetID,
         from: Option<Address>,
         collateral: TokenAmount,
-        metadata: Vec<u8>,
+        public_key: Vec<u8>,
     ) -> anyhow::Result<()> {
         let parent = subnet.parent().ok_or_else(|| anyhow!("no parent found"))?;
         let conn = match self.connection(&parent) {
@@ -274,7 +274,7 @@ impl IpcProvider {
         let sender = self.check_sender(subnet_config, from)?;
 
         conn.manager()
-            .join_subnet(subnet, sender, collateral, metadata)
+            .join_subnet(subnet, sender, collateral, public_key)
             .await
     }