Merge pull request #379 from consensus-shipyard/ipc-373-fix-balances

IPC-373: Fix balances returned with bogus rpc

ipc/cli/src/commands/wallet/balances.rs

@@ -26,11 +26,12 @@ impl CommandLineHandler for WalletBalances {
 
         let wallet_type = WalletType::from_str(&arguments.wallet_type)?;
         let subnet = SubnetID::from_str(&arguments.subnet)?;
+        let mut errors = Vec::new();
+
         match wallet_type {
             WalletType::Evm => {
                 let wallet = provider.evm_wallet()?;
                 let addresses = wallet.read().unwrap().list()?;
-                let mut no_balance = addresses.clone();
                 let r = addresses
                     .iter()
                     .map(|addr| {
@@ -50,15 +51,27 @@ impl CommandLineHandler for WalletBalances {
 
                 let v: Vec<anyhow::Result<(TokenAmount, &EthKeyAddress)>> = join_all(r).await;
 
-                for r in v.into_iter().filter_map(|r| r.ok()) {
-                    let (balance, addr) = r;
-                    if addr.to_string() != "default-key" {
-                        println!("{} - Balance: {}", addr.to_string(), balance);
-                        no_balance.retain(|a| a != addr);
+                for r in v.into_iter() {
+                    match r {
+                        Ok(i) => {
+                            let (balance, addr) = i;
+                            if addr.to_string() != "default-key" {
+                                println!("{} - Balance: {}", addr.to_string(), balance);
+                            }
+                        }
+                        Err(e) => {
+                            errors.push(e);
+                        }
                     }
                 }
-                for addr in no_balance {
-                    println!("{} - Balance: 0", addr.to_string());
+
+                if !errors.is_empty() {
+                    let error = errors
+                        .into_iter()
+                        .fold(anyhow::anyhow!("Error fetching balances"), |acc, err| {
+                            acc.context(err)
+                        });
+                    return Err(error);
                 }
             }
             WalletType::Fvm => {