Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

FM-17: Map events to ABCI #33

Merged
merged 2 commits into from
Feb 16, 2023
Merged

FM-17: Map events to ABCI #33

merged 2 commits into from
Feb 16, 2023

Conversation

aakoshh
Copy link
Contributor

@aakoshh aakoshh commented Feb 16, 2023

Closes consensus-shipyard/ipc#286

Now that a new version of fvm_shared made the necessary fields public, was able to finish mapping events.

I think the Go version of EventAttribute might accept bytes, which it turns into Base64 strings during serialization; the Rust library expects String for key and value, which it will encode as Base64. The value coming from StampedEvent is Vec<u8>, so I first converted it hex, which then will be converted into Base64, which is a bit ugly, but not sure what else I could do (apart from double Base64 encoding, which could be shorter, but perhaps we use hex more often).

Here are some relevant docs:

@aakoshh aakoshh requested a review from adlrocha February 16, 2023 10:43
@aakoshh aakoshh merged commit e997fbd into master Feb 16, 2023
@aakoshh aakoshh deleted the fm-17-abci-events branch February 16, 2023 11:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map events to ABCI
1 participant