This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes consensus-shipyard/ipc#286
Now that a new version of
fvm_shared
made the necessary fields public, was able to finish mapping events.I think the Go version of
EventAttribute
might acceptbytes
, which it turns into Base64 strings during serialization; the Rust library expectsString
for key and value, which it will encode as Base64. The value coming fromStampedEvent
isVec<u8>
, so I first converted ithex
, which then will be converted into Base64, which is a bit ugly, but not sure what else I could do (apart from double Base64 encoding, which could be shorter, but perhaps we use hex more often).Here are some relevant docs: