-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
f532117
to
9414f71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The high-level idea LGTM and I like the abstractions we are using. My only concern is the same as in the previous PRs, while the protocol would work end-to-end if all peers where Fendermint-based, we may need to simplify it a bit to support mainnet interactions.
let smsg = relayed_bottom_up_ckpt_to_fvm(&msg) | ||
.context("failed to syntesize FVM message")?; | ||
|
||
// Let the FVM validate the checkpoint quorum certificate and take not of the relayer for rewards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me see if I understand this. The idea is that:
- There is a
Resolve
message committing the checkpoint which includes theCid
of the list of bottom-up messages to be executed. - If the commitment happens, the
Cid
of the messages are queue for resolution and a posterior proposal an execution?
I still think we may need to remove the resolution stage and directly include messages as part of the checkpoint in a first implementation. Message resolution may include additional complexity in the L2->root interaction :(
In any case, I feel this will make more sense as I move towards the implementation of the actual execution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you got that right, and as per our sync we will implement both behaviours depending on what kind of parent we'll be dealing with. For Fendermint<-Fendermint relationships we will use this, for Lotus<-Fendermint we won't.
06e0dc4
to
1fdbde4
Compare
Co-authored-by: adlrocha <[email protected]>
bd53e3f
to
48d9336
Compare
Closes consensus-shipyard/ipc#313
Depends on #198
The PR looks bigger than it is because it merged
main
, and because after runningcargo update
there are lots of changes toCargo.lock
andethers
also generated different code for Solidity actors. We can rebase once the dependencies are merged.BottomUpResolve
to a message we can send to the FVM (does not include cross-messages, just for quorum certificate validation and reward tracking)