Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting rust-version in Cargo.toml #73

Closed
konstin opened this issue Aug 30, 2022 · 5 comments
Closed

Setting rust-version in Cargo.toml #73

konstin opened this issue Aug 30, 2022 · 5 comments

Comments

@konstin
Copy link

konstin commented Aug 30, 2022

Would it be possible to set the rust-version field in Cargo.toml? We would like to support rust 1.59 and therefore currently have to pin rpassword ^6, with the rust-version we go switch to rpassword ^6 || ^7

@messense
Copy link
Contributor

messense commented Aug 31, 2022

The 7.0.0 release notes says You will need at least Rust 1.59 to use this new release., but it's not true, the new dep:xxx syntax for Cargo features are stabilized in Rust 1.60.0.

@conradkleinespel
Copy link
Owner

@messense Oh alright, I'll go ahead and change the description of the release then. Thanks for the hint!

@conradkleinespel
Copy link
Owner

@konstin I didn't know there was a field for that. That's good to know! It would make sense to use it, yes 👍

@conradkleinespel
Copy link
Owner

conradkleinespel commented Aug 31, 2022

@konstin I don't have much time to work on rpassword at the moment but when I get a chance, I'll add a rust-version field. When it's done I'll make sure to update this issue so you're aware of the change.

LSchallot added a commit to LSchallot/rpassword that referenced this issue Sep 9, 2022
…d updated string cleanup to handle ctrl+u (fixes issue conradkleinespel#70)
@conradkleinespel
Copy link
Owner

Fixed with help from @LSchallot and published in v7.1.0 on crates.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants