Updates gen-feature to allow an array of files to extend from, and to only filter exclusions from those files #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This will allow us to compose multiple feature files together.
- It doesn't make sense to exclude features that are local, since typically we're extending with the sole purpose of adding them in. This will make it so we can exclude things but not have to avoid clashing with local names (for instance, swapping out an app for a slightly extended version will no longer require making each have a unique name).
vinamartin
approved these changes
Feb 12, 2020
|
We have a use case where we need to extend multiple feature files? |
|
With the splitting out of some UI features but not all, yes. We want to extend catalog-ui-search which is in ddf-ui, and the admin ui which is in ddf. |
Bdthomson
approved these changes
Feb 12, 2020
djblue
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight updates to gen-feature to allow passing in multiple files to extend from, and to make it so we don't have to name bundles that are being replaced by local bundles differently (by making the filtering of exclusions only happen on the pass in files).