Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix some typos in comments #6085

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: fix some typos in comments #6085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/agents/lighthouse/test/mock.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ export const mock = {
},
wallet: (): SinonStubbedInstance<Wallet> => {
const wallet = createStubInstance(Wallet);
// need to do this differently bc the function doesnt exist on the interface
// need to do this differently bc the function doesn't exist on the interface
(wallet as any).address = mock.address.router;
wallet.getAddress.resolves(mock.address.router);
wallet.signMessage.resolves(mock.signature);
Expand Down
2 changes: 1 addition & 1 deletion packages/agents/router/test/mock.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ export const mock = {
adapters: {
wallet: (): SinonStubbedInstance<Wallet> => {
const wallet = createStubInstance(Wallet);
// need to do this differently bc the function doesnt exist on the interface
// need to do this differently bc the function doesn't exist on the interface
(wallet as any).address = mock.address.router;
wallet.getAddress.resolves(mock.address.router);
wallet.signMessage.resolves(mock.signature);
Expand Down
2 changes: 1 addition & 1 deletion packages/agents/watcher/test/operations/validateAndPause.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ describe("Operations:validateAndPause", () => {
validateAndPauseStub = stub(ValidateAndPauseFns, "pauseAndAlert").resolves();
});

it("should not call pauseAndAlert if it doesnt need pause", async () => {
it("should not call pauseAndAlert if it doesn't need pause", async () => {
(ctxMock.adapters.watcher.checkInvariants as SinonStub).resolves({ needsPause: false });
await ValidateAndPauseFns.validateAndPause();
expect(validateAndPauseStub.callCount).to.be.eq(0);
Expand Down
2 changes: 1 addition & 1 deletion packages/agents/watcher/test/operations/validateAndSwitch.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ describe("Operations:validateAndSwitch", () => {
validateAndSwitchStub = stub(validateAndSwitchFns, "switchAndAlert").resolves();
});

it("should not call switchAndAlert if it doesnt need pause", async () => {
it("should not call switchAndAlert if it doesn't need pause", async () => {
(ctxMock.adapters.monitor.validateProposal as SinonStub).resolves({ needsSwitch: false });
await validateAndSwitchFns.validateAndSwitch();
expect(validateAndSwitchStub.callCount).to.be.eq(0);
Expand Down
2 changes: 1 addition & 1 deletion packages/deployments/contracts/contracts/messaging/RootManager.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ contract RootManager is ProposedOwnable, IRootManager, WatcherClient, DomainInde

/**
* @notice Emitted when a root is propagated
* @dev It doesnt matter if the root was generated optimistically or on-chain.
* @dev It doesn't matter if the root was generated optimistically or on-chain.
* @param aggregateRoot The aggregate root propagated
* @param domainsHash The current domain hash
*/
Expand Down
4 changes: 2 additions & 2 deletions packages/deployments/contracts/contracts_forge/core/connext/libraries/AssetLogic.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ contract AssetLogicTest is BaseConnextFacet, FacetHelper {

// ============ swapToLocalAssetIfNeeded ============

// doesnt swap
// doesn't swap
function test_AssetLogic__swapToLocalAssetIfNeeded_worksIfZero() public {
utils_swapToLocalAndAssertViaExternal(_adopted, 0, 10000, 1_000);
}
Expand All @@ -327,7 +327,7 @@ contract AssetLogicTest is BaseConnextFacet, FacetHelper {

// ============ swapFromLocalAssetIfNeeded ============

// doesnt swap
// doesn't swap
function test_AssetLogic__swapFromLocalAssetIfNeeded_worksIfZero() public {
utils_swapFromLocalAndAssertViaExternal(_local, 0, 0.1 ether, 1_000, 0 ether);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/deployments/subgraph/src/amarok-hub-staging/mapping/rootManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import {

import {
OptimisticRootPropagated,
RootAggregated, //TOOD: V1.1 Remove
RootAggregated, //TODO: V1.1 Remove
RootManagerMeta,
RootManagerMode,
OptimisticRootProposed,
Expand Down
2 changes: 1 addition & 1 deletion packages/integration/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ A test script to validate the end-to-end cross-chain transfer process.

### 2. Environment Variables

In your local environment, relpace `sha-0c08528` to the latest sha build tag from CI you want to use, run the following commands to export env variables which will be used in the local e2e runtime environment:
In your local environment, replace `sha-0c08528` to the latest sha build tag from CI you want to use, run the following commands to export env variables which will be used in the local e2e runtime environment:

```sh
export ROUTER_PUBLISHER_IMAGE='ghcr.io/connext/router-publisher:sha-0c08528'
Expand Down