Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5877 reset errors #5900

Merged
merged 3 commits into from
Mar 21, 2024
Merged

5877 reset errors #5900

merged 3 commits into from
Mar 21, 2024

Conversation

LayneHaber
Copy link
Contributor

Description

  • Resets the error_status along with backoff and execution timeouts

Type of change

  • Docs change / dependency upgrade
  • Configuration / tooling changes
  • Refactoring
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires changes in customer code

High-level change(s) description - from the user's perspective

TLDR:

  • transfer error statuses are not always updated dynamically, they update according to an exponential backoff
  • this could cause stale errors, particularly around relayer fees and slippage which are moment-in-time evaluation
  • slippage / relayer fee changes reset the backoff, but not always the error which leaves the error handling to be offloaded onto the client, and is not indicative of the error on the latest transfer params
  • there could be other issues around the errors being stale, which we will have to resolve manually, but resetting the errors on increase will help as well

Considered making a separate database function or flag, but resetBackoffs is only ever used in the case new slippage or relayer fee updates come in.

Related Issue(s)

Fixes #5877
Fixes #5892

Related pull request(s)

@preethamr preethamr merged commit 65dc719 into main Mar 21, 2024
22 checks passed
@preethamr preethamr deleted the 5877-reset-errors branch March 21, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ST] Txn stuck at bump relayer fees step [ST] Execution error
2 participants