-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zero basis fees #5857
Merged
Merged
Zero basis fees #5857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LayneHaber
requested review from
preethamr,
liu-zhipeng,
wanglonghong and
just-a-node
as code owners
March 15, 2024 23:38
prathmeshkhandelwal1
previously approved these changes
Mar 17, 2024
proveAndProcessL1: "20000", | ||
// monthly costs in weth / monthly transfer count = weth cost per transfer | ||
// weth. chaindata should be updated when switching between op and slow mode | ||
messaging: "4500", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am just wondering why we need messaging
item here?
Does this only work in slow mode to go through AMB?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is for the optimistic messaging overhead
wanglonghong
previously approved these changes
Mar 18, 2024
wanglonghong
dismissed stale reviews from prathmeshkhandelwal1 and themself
via
March 18, 2024 03:00
0c51827
wanglonghong
previously approved these changes
Mar 18, 2024
This was referenced Mar 18, 2024
Closed
preethamr
approved these changes
Mar 18, 2024
liu-zhipeng
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To release without increased
LowRelayerFee
errors requires:Type of change
High-level change(s) description - from the user's perspective
Related Issue(s)
Fixes
Related pull request(s)