Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero basis fees #5857

Merged
merged 7 commits into from
Mar 19, 2024
Merged

Zero basis fees #5857

merged 7 commits into from
Mar 19, 2024

Conversation

LayneHaber
Copy link
Contributor

@LayneHaber LayneHaber commented Mar 15, 2024

Description

  • Adds ability to account for proving and messaging fees
  • Provides defaults, but looks to chain data first
  • Expected relayer fee increase by ~30%

To release without increased LowRelayerFee errors requires:

  • Update chaindata repository to contain default values
  • Migrating to prod with feature flag in the sequencer
  • Release of new utils + sdk package
  • Updating sdk integrations and hosted agent
  • Update sequencer with feature flag

Type of change

  • Docs change / dependency upgrade
  • Configuration / tooling changes
  • Refactoring
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires changes in customer code

High-level change(s) description - from the user's perspective

Related Issue(s)

Fixes

Related pull request(s)

proveAndProcessL1: "20000",
// monthly costs in weth / monthly transfer count = weth cost per transfer
// weth. chaindata should be updated when switching between op and slow mode
messaging: "4500",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am just wondering why we need messaging item here?

Does this only work in slow mode to go through AMB?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is for the optimistic messaging overhead

wanglonghong
wanglonghong previously approved these changes Mar 18, 2024
@wanglonghong wanglonghong dismissed stale reviews from prathmeshkhandelwal1 and themself via 0c51827 March 18, 2024 03:00
wanglonghong
wanglonghong previously approved these changes Mar 18, 2024
@wanglonghong wanglonghong merged commit 90e7c5b into main Mar 19, 2024
22 checks passed
@wanglonghong wanglonghong deleted the zero-basis-fees branch March 19, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants