Create memhttp package to debug flaky testcases

.golangci.yml

@@ -119,3 +119,9 @@ issues:
     - linters: [revive]
       text: "^if-return: "
       path: error_writer.go
+    # We want to set http.Server's logger
+    - linters: [forbidigo]
+      path: internal/memhttp
+    # We want to show examples with http.Get
+    - linters: [noctx]
+      path: internal/memhttp/memhttp_test.go

client_example_test.go

@@ -27,9 +27,8 @@ import (
 
 func Example_client() {
 	logger := log.New(os.Stdout, "" /* prefix */, 0 /* flags */)
-	// Unfortunately, pkg.go.dev can't run examples that actually use the
-	// network. To keep this example runnable, we'll use an HTTP server and
-	// client that communicate over in-memory pipes. The client is still a plain
+	// To keep this example runnable, we'll use an HTTP server and client
+	// that communicate over in-memory pipes. The client is still a plain
 	// *http.Client!
 	var httpClient *http.Client = examplePingServer.Client()
 

client_ext_test.go

@@ -18,14 +18,14 @@ import (
 	"context"
 	"errors"
 	"net/http"
-	"net/http/httptest"
 	"strings"
 	"testing"
 
 	connect "connectrpc.com/connect"
 	"connectrpc.com/connect/internal/assert"
 	pingv1 "connectrpc.com/connect/internal/gen/connect/ping/v1"
 	"connectrpc.com/connect/internal/gen/connect/ping/v1/pingv1connect"
+	"connectrpc.com/connect/internal/memhttp/memhttptest"
 )
 
 func TestNewClient_InitFailure(t *testing.T) {
@@ -75,16 +75,13 @@ func TestClientPeer(t *testing.T) {
 	t.Parallel()
 	mux := http.NewServeMux()
 	mux.Handle(pingv1connect.NewPingServiceHandler(pingServer{}))
-	server := httptest.NewUnstartedServer(mux)
-	server.EnableHTTP2 = true
-	server.StartTLS()
-	t.Cleanup(server.Close)
+	server := memhttptest.NewServer(t, mux)
 
 	run := func(t *testing.T, unaryHTTPMethod string, opts ...connect.ClientOption) {
 		t.Helper()
 		client := pingv1connect.NewPingServiceClient(
 			server.Client(),
-			server.URL,
+			server.URL(),
 			connect.WithClientOptions(opts...),
 			connect.WithInterceptors(&assertPeerInterceptor{t}),
 		)
@@ -111,6 +108,8 @@ func TestClientPeer(t *testing.T) {
 		// server streaming
 		serverStream, err := client.CountUp(ctx, connect.NewRequest(&pingv1.CountUpRequest{}))
 		t.Cleanup(func() {
+			// TODO(emcfarlane): debug flaky test close with error:
+			// "unknown: io: read/write on closed pipe"
 			assert.Nil(t, serverStream.Close())
 		})
 		assert.Nil(t, err)
@@ -157,14 +156,10 @@ func TestGetNotModified(t *testing.T) {
 
 	mux := http.NewServeMux()
 	mux.Handle(pingv1connect.NewPingServiceHandler(&notModifiedPingServer{etag: etag}))
-	server := httptest.NewUnstartedServer(mux)
-	server.EnableHTTP2 = true
-	server.StartTLS()
-	t.Cleanup(server.Close)
-
+	server := memhttptest.NewServer(t, mux)
 	client := pingv1connect.NewPingServiceClient(
 		server.Client(),
-		server.URL,
+		server.URL(),
 		connect.WithHTTPGet(),
 	)
 	ctx := context.Background()

client_get_fallback_test.go

@@ -17,12 +17,12 @@ package connect
 import (
 	"context"
 	"net/http"
-	"net/http/httptest"
 	"strings"
 	"testing"
 
 	"connectrpc.com/connect/internal/assert"
 	pingv1 "connectrpc.com/connect/internal/gen/connect/ping/v1"
+	"connectrpc.com/connect/internal/memhttp/memhttptest"
 )
 
 func TestClientUnaryGetFallback(t *testing.T) {
@@ -38,14 +38,11 @@ func TestClientUnaryGetFallback(t *testing.T) {
 		},
 		WithIdempotency(IdempotencyNoSideEffects),
 	))
-	server := httptest.NewUnstartedServer(mux)
-	server.EnableHTTP2 = true
-	server.StartTLS()
-	t.Cleanup(server.Close)
+	server := memhttptest.NewServer(t, mux)
 
 	client := NewClient[pingv1.PingRequest, pingv1.PingResponse](
 		server.Client(),
-		server.URL+"/connect.ping.v1.PingService/Ping",
+		server.URL()+"/connect.ping.v1.PingService/Ping",
 		WithHTTPGet(),
 		WithHTTPGetMaxURLSize(1, true),
 		WithSendGzip(),

compression_test.go

@@ -17,10 +17,10 @@ package connect
 import (
 	"context"
 	"net/http"
-	"net/http/httptest"
 	"testing"
 
 	"connectrpc.com/connect/internal/assert"
+	"connectrpc.com/connect/internal/memhttp/memhttptest"
 	"google.golang.org/protobuf/types/known/emptypb"
 )
 
@@ -42,12 +42,10 @@ func TestAcceptEncodingOrdering(t *testing.T) {
 		w.WriteHeader(http.StatusOK)
 		called = true
 	})
-	server := httptest.NewServer(verify)
-	t.Cleanup(server.Close)
-
+	server := memhttptest.NewServer(t, verify)
 	client := NewClient[emptypb.Empty, emptypb.Empty](
 		server.Client(),
-		server.URL,
+		server.URL(),
 		withFakeBrotli,
 		withGzip(),
 	)