Introduce ConnectRouter.rpc overload to not require full ServiceType #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-sachs
changed the title
paul-sachs
changed the title
paul-sachs
commented
Oct 25, 2023
timostamm
reviewed
Oct 26, 2023
timostamm
reviewed
Oct 26, 2023
There was a problem hiding this comment.
Looks great to me.
@srikrsna-buf, do you know of a use case for localName we missed? bufbuild/protobuf-es#594 (comment)
Co-authored-by: Timo Stamm <[email protected]>
timostamm
approved these changes
Oct 27, 2023
|
Continuing PR in fork based PR: #925 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly copied from bufbuild/protobuf-es#594:
ConnectRouter.rpcoverload that doesn't require the full service is easier to use for one off methods that don't require an entire service to be defined.