Add tests for omitted message in connect error #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Stamm <[email protected]>
Signed-off-by: Timo Stamm <[email protected]>
jhump
reviewed
Sep 10, 2024
| @@ -83,6 +83,25 @@ testCases: | |||
| error: | |||
| code: CODE_UNAVAILABLE | |||
| message: oops | |||
| - request: | |||
| testName: error/message-omitted | |||
There was a problem hiding this comment.
For consistency with above test case (named missing-code), how about missing-message instead?
There was a problem hiding this comment.
Code is required, but message is optional, so it isn't really missing. Maybe that's splitting hairs... I've renamed to missing-message for consistency, and added a comment explaining it's optional.
Signed-off-by: Timo Stamm <[email protected]>
jhump
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "message" property in a Connect Error or EndStreamResponse is optional. This PR adds tests for clients to make sure they are able to parse a response where "message" is omitted.