-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix cancellation and timeout failures (#734)
This makes various improvements to fix the failing cancellation and timeout tests: * Removes `ctx.Err()` checks in the clients since this can be an ambiguous error on the client and could potentially be unrelated to the error we received from the RPC framework. * Adds logic to immediately send response headers on server and bidi streams so that clients can be unblocked reading this data. Previously this was causing clients to block on reading this data and was preventing them from cancelling at the intended time. * Adds docs to the protos specifying the above. * Adds cancellation logic to gRPC `BidiStream` * Configures some tests with appropriate delays so that the cancellation is properly communicated. All of the tests in `bidi-cancellation.yaml` and `bidi-timeouts.yaml` have been folded into the `basic.yaml` suite of tests since these apply to and pass all permutations.
- Loading branch information
Showing
12 changed files
with
454 additions
and
385 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
223 changes: 0 additions & 223 deletions
223
internal/app/connectconformance/testsuites/bidi-cancellation.yaml
This file was deleted.
Oops, something went wrong.
46 changes: 0 additions & 46 deletions
46
internal/app/connectconformance/testsuites/bidi-timeouts.yaml
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.