Fixes table of contents navigation active link #359
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since making updates to the SgNavigation; how we gathered and located active link's index has changed. I've updated the code to be a bit more agnostic at how it gets an actual index now of links, vs trying to get a pointer to markup.
Motivation and Context
Fixes active or rather current link state. Without this fix, all pages you visit will always list the first link in the navigation as active page.
How Has This Been Tested?
While running a dev build, test the navigation links by clicking a few pages and confirm the active state follows you from page to page now.
Make sure:
All are working still.
Thanks!
Types of changes
Checklist: