Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes table of contents navigation active link #359

Merged
merged 4 commits into from
Mar 19, 2018

Conversation

drolsen
Copy link
Member

@drolsen drolsen commented Mar 19, 2018

Description

Since making updates to the SgNavigation; how we gathered and located active link's index has changed. I've updated the code to be a bit more agnostic at how it gets an actual index now of links, vs trying to get a pointer to markup.

Motivation and Context

Fixes active or rather current link state. Without this fix, all pages you visit will always list the first link in the navigation as active page.

How Has This Been Tested?

While running a dev build, test the navigation links by clicking a few pages and confirm the active state follows you from page to page now.

Make sure:

  • dev build
  • full build
  • production build

All are working still.
Thanks!

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@drolsen drolsen requested a review from pgregorova March 19, 2018 19:52
@drolsen drolsen merged commit d5fc8da into develop Mar 19, 2018
@drolsen drolsen deleted the bugfix/active-toc-links branch March 19, 2018 21:16
@drolsen drolsen mentioned this pull request Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant