Style Guide Nav Icons & Ordering #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bstaruk
changed the title
drolsen
approved these changes
Mar 17, 2018
drolsen
requested changes
Mar 17, 2018
| @@ -22,13 +20,7 @@ export const SgPageShell__navigation = (props) => { | |||
|
|
|||
| return ( | |||
| <nav className={classStack} {...attrs}> | |||
| <Scrollbars | |||
There was a problem hiding this comment.
Lets leave the custom scroll bars please. This is for Windows users like me who don't get nice fancy thin OSX scroll bars :D
| @@ -58,9 +50,9 @@ export const SgPageShell__main = (props) => { | |||
| ]); | |||
|
|
|||
| return ( | |||
| <div className={classStack} {...attrs} role="main" id="sg-main"> | |||
| <main className={classStack} {...attrs} role="main" id="sg-main"> | |||
There was a problem hiding this comment.
Is this to fix a console warning?
| @@ -86,13 +78,7 @@ export const SgPageShell = (props) => { | |||
|
|
|||
| return ( | |||
| <div className={classStack} {...attrs}> | |||
| <Scrollbars | |||
There was a problem hiding this comment.
Lets leave the custom scroll bars please. This is for Windows users like me who don't get nice fancy thin OSX scroll bars :D
drolsen
approved these changes
Mar 17, 2018
9 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings icons to our style guide navigation headings, and re-orders the nav sections to be a bit more intuitive.
Note that some changes were made to the SgPageShell style guide molecule, imported from the same project that the icons were. @drolsen, please be sure to pay special attention to these changes while testing/reviewing.
Motivation and Context
We've implemented these changes on another project and it looked great, so we're bringing it into FC core.
Types of changes
Checklist: