Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Missing "devNotes" Bug #339

Merged
merged 1 commit into from
Feb 8, 2018
Merged

Resolve Missing "devNotes" Bug #339

merged 1 commit into from
Feb 8, 2018

Conversation

bstaruk
Copy link
Contributor

@bstaruk bstaruk commented Feb 8, 2018

Description

There was recently a slight oversight that resulted in our "devNotes" functionality being lost on styleguide examples. This branch contains a fix for that.

How Has This Been Tested?

Build, production, test & dev commands have been run without issue.

To test the actual devNotes functionality in the styleguide, add a devNotes (string) prop to any example (along with name and component) and you'll see the button show up alongside the HTML & React buttons on the example.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@drolsen
Copy link
Member

drolsen commented Feb 8, 2018

omg

Oops!
Confirm fixed, thanks @bstaruk !

@drolsen drolsen merged commit 9b5e64b into develop Feb 8, 2018
@drolsen drolsen deleted the bug-fix/devNotes branch February 8, 2018 16:02
@drolsen drolsen mentioned this pull request Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants