Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add captureException() wrapper #616

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

add captureException() wrapper #616

wants to merge 10 commits into from

Conversation

shouples
Copy link
Contributor

@shouples shouples commented Nov 16, 2024

Summary of Changes

Adds a wrapper around our Sentry.captureException() calls to automatically include the ObservabilityContext as part of the event extra, and also include convenience ResponseContext status if the passed error is one of our supported ResponseError types. This will also include the associated x-connection-id header so we can see if the captured response error came from a CCloud or local connection (and eventually UUIDs for direct connections).

Pull request checklist

Please check if your PR fulfills the following (if applicable):

Tests
  • Added new
  • Updated existing
  • Deleted existing
Other
  • All new disposables (event listeners, views, channels, etc.) collected as for eventual cleanup?
  • Does anything in this PR need to be mentioned in the user-facing CHANGELOG or README?
  • Have you validated this change locally by packaging and installing the extension .vsix file?
    gulp clicktest

@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Base automatically changed from djs/obs-context to main November 19, 2024 17:32
@shouples shouples mentioned this pull request Nov 21, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create captureException wrapper function to add ObservabilityContext to Sentry errors
1 participant