-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add captureException()
wrapper
#616
Draft
shouples
wants to merge
10
commits into
main
Choose a base branch
from
djs/obs-sentry
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+157
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
airlock-confluentinc
bot
force-pushed
the
djs/obs-context
branch
from
November 19, 2024 01:14
8eed1f7
to
364d1ad
Compare
airlock-confluentinc
bot
force-pushed
the
djs/obs-sentry
branch
from
November 19, 2024 14:49
bc947b1
to
b12699c
Compare
🎉 All Contributor License Agreements have been signed. Ready to merge. |
airlock-confluentinc
bot
force-pushed
the
djs/obs-sentry
branch
from
November 27, 2024 00:44
80974f3
to
d044df6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Adds a wrapper around our
Sentry.captureException()
calls to automatically include theObservabilityContext
as part of the eventextra
, and also include convenienceResponseContext
status if the passed error is one of our supportedResponseError
types. This will also include the associatedx-connection-id
header so we can see if the captured response error came from a CCloud or local connection (and eventually UUIDs for direct connections).Pull request checklist
Please check if your PR fulfills the following (if applicable):
Tests
Other
.vsix
file?