Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove all commands that resulted in "COMING SOON" notifications #420

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

shouples
Copy link
Contributor

@shouples shouples commented Oct 22, 2024

Summary of Changes

Closes #283.

Instead of showing actions that we intend to include (but are blocked by sidecar updates or other dependencies), we're hiding them from the UI entirely. The comments around the associated code now also link to this PR so it should be easy to revert the when clauses in package.json once we get around to implementing the associated functionality.

The following were also blocked from showing up in the command palette and may need to be reverted once we implement them:

  • confluent.kafka-clusters.item.rename
  • confluent.resources.item.rename

The three confluent.schemaViewer.* commands already had a when: false section in the command palette.

Pull request checklist

Please check if your PR fulfills the following (if applicable):

Tests
  • Added new
  • Updated existing
  • Deleted existing
Other
  • Does anything in this PR need to be mentioned in the user-facing CHANGELOG or README?
  • Have you validated this change locally by packaging and installing the extension .vsix file?
    gulp clicktest

@shouples shouples marked this pull request as ready for review October 22, 2024 18:34
@shouples shouples requested a review from a team as a code owner October 22, 2024 18:34
noeldevelops
noeldevelops previously approved these changes Oct 22, 2024
Copy link
Member

@noeldevelops noeldevelops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@shouples shouples marked this pull request as draft October 22, 2024 18:37
@shouples shouples merged commit 3c3eddb into main Oct 22, 2024
1 check passed
@shouples shouples deleted the djs/hide-coming-soon-features branch October 22, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nit: Unavailable action should be hidden/disabled
2 participants