DGS-6373 Ignore leading dot when merging Protobuf custom options (#2577)

confluentinc · Mar 15, 2023 · b04f05e · b04f05e
1 parent eab6ead
commit b04f05e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/...buf-provider/src/main/java/io/confluent/kafka/schemaregistry/protobuf/ProtobufSchema.java b/...buf-provider/src/main/java/io/confluent/kafka/schemaregistry/protobuf/ProtobufSchema.java
@@ -1132,7 +1132,7 @@ private static Map<String, OptionElement> mergeOptions(List<OptionElement> optio
     // which may not be using the alternative aggregate syntax.
     return options.stream()
         .collect(Collectors.toMap(
-            OptionElement::getName,
+            o -> o.getName().startsWith(".") ? o.getName().substring(1) : o.getName(),
             o -> o,
             ProtobufSchema::merge));
   }

diff --git a/...provider/src/test/java/io/confluent/kafka/schemaregistry/protobuf/ProtobufSchemaTest.java b/...provider/src/test/java/io/confluent/kafka/schemaregistry/protobuf/ProtobufSchemaTest.java
@@ -417,7 +417,7 @@ public void testComplexCustomOptions() {
         + "option java_multiple_files = true;\n"
         + "option (com.custom.map).subject = 'user-value';\n"
         + "option (com.custom.map).compatibility_mode = FULL;\n"
-        + "option (confluent.file_meta).doc = \"file meta\";\n"
+        + "option (.confluent.file_meta).doc = \"file meta\";\n"
         + "option (confluent.file_meta).params = [\n"
         + "      {\n"
         + "        value: \"my_value\",\n"
@@ -438,7 +438,7 @@ public void testComplexCustomOptions() {
         + "option java_multiple_files = true;\n"
         + "option (com.custom.map).subject = \"user-value\";\n"
         + "option (com.custom.map).compatibility_mode = FULL;\n"
-        + "option (confluent.file_meta).doc = \"file meta\";\n"
+        + "option (.confluent.file_meta).doc = \"file meta\";\n"
         + "option (confluent.file_meta).params = [{\n"
         + "  value: \"my_value\",\n"
         + "  key: \"my_key\"\n"