Always define rd_ut_coverage_check #4862
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
|
|
StephanDollberg
force-pushed
the
stephan/lld-fix
branch
from
b6a11e3 to
e3f2523
Compare
Define `rd_ut_coverage_check` even in non-devel mode as the `lds-gen.py` script adds the symbol unconditionally. Otherwise LLD complains about ld: ``` error: version script assignment of 'global' to symbol 'rd_ut_coverage_check' failed: symbol not defined ``` Fixes confluentinc#4593
StephanDollberg
force-pushed
the
stephan/lld-fix
branch
from
e3f2523 to
4e87763
Compare
1 task
nassibnassar
added a commit
to nassibnassar/librdkafka
that referenced
this pull request
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define
rd_ut_coverage_checkeven in non-devel mode as thelds-gen.pyscript adds the symbol unconditionally.
Otherwise LLD complains about ld:
Fixes #4593