-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata cache by topic id #4676
Conversation
4b8eb2d
to
4d7eab9
Compare
if (old) | ||
/* Insert (and replace existing) entry into the AVL tree sorted | ||
* by topic id. */ | ||
if (!RD_KAFKA_UUID_IS_ZERO( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should check this whole logic again. This is tricky and might have some issues.
improve documentation of Metadata functions
4d7eab9
to
8ea3b9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just few minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!.. Nice changes!
improve documentation of Metadata functions
improve documentation of Metadata functions
improve documentation of Metadata functions
and improved documentation of Metadata functions