Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ListGroup protocol message for ApiVersion >= 3 #4207

Merged
merged 3 commits into from
Mar 10, 2023
Merged

Fix ListGroup protocol message for ApiVersion >= 3 #4207

merged 3 commits into from
Mar 10, 2023

Conversation

milindl
Copy link
Contributor

@milindl milindl commented Mar 3, 2023 •
edited
Loading

Earlier, we were adding extra tagged fields when the version was a flexver. (The tagged fields are added at a common place, so this was extra)

I've run tests 0081 and 0080

@milindl milindl requested a review from emasab March 3, 2023 09:28
@milindl
Copy link
Contributor Author

milindl commented Mar 3, 2023

The test failure, seems very unrelated

main_0001_multiobj():94: full create-produce-destroy cycle: expected duration 0 <= 1409 <= 999 ms 03

And the windows build is failing because of the coapp issue

emasab
emasab approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@milindl milindl merged commit 578589d into master Mar 10, 2023
@milindl milindl deleted the dev_list_protocol_req_change branch March 10, 2023 10:24
pranavrth pushed a commit that referenced this pull request Mar 13, 2023
@milindl @emasab @pranavrth
Fix ListGroup protocol message for ApiVersion >= 3 (#4207)
024c09f 
Co-authored-by: Emanuele Sabellico <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emasab emasab emasab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milindl @emasab