Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs around the use of the TIMESTAMP field #783

Merged
merged 7 commits into from
Feb 27, 2018

Conversation

big-andy-coates
Copy link
Contributor

@big-andy-coates big-andy-coates commented Feb 23, 2018

To resolve #782

While working through the docs it was not very clear to me what the TIMESTAMP property on the CREATE calls was doing. Here's a stab at clarifying their purpose...

Assuming my assumptions on how it works are correct, what is still not clear to me is what the behavior would be if TIMESTAMP was not supplied where the SELECT was a join. Which source would it take the timestamp from?

…in the CREATE statements, and the default behaviour where it is not supplied.
@big-andy-coates big-andy-coates requested a review from a team February 23, 2018 16:22
Copy link
Contributor

@joel-hamill joel-hamill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@big-andy-coates changes look good. please rebase and migrate into the newly migrated .rst source.

@big-andy-coates big-andy-coates merged commit cc2d189 into confluentinc:4.1.x Feb 27, 2018
@big-andy-coates big-andy-coates deleted the improve_ts_docs branch February 27, 2018 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants