Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add idle timeout #7556

Merged
merged 1 commit into from
May 20, 2021
Merged

feat: add idle timeout #7556

merged 1 commit into from
May 20, 2021

Conversation

vvcephei
Copy link
Member

Description

Expose a config to set the server's idle timeout to work around #6970

Testing done

Set the configuration to 5 seconds, ran the server locally, and verified that when I create a transient query on the HTTP2 API, the connection gets closed after 5 seconds of inactivity. I also verified that if I cancel my query (Ctrl-C on my curl command), the transient query gets shut down on the server.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@vvcephei vvcephei requested a review from a team as a code owner May 19, 2021 22:24
@ghost
Copy link

ghost commented May 19, 2021

@confluentinc It looks like @vvcephei just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@agavra agavra changed the title testing: add idle timeout test: add idle timeout May 19, 2021
Copy link
Contributor

@agavra agavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice - I think having this config also gives us a workaround for customers that need it. I think we should have this regardless of whether or not we end up doing #7555

if we are concerned with 24h, we can start the default at 1h and then allow customers to increase it.

Copy link
Contributor

@guozhangwang guozhangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @vvcephei

@guozhangwang
Copy link
Contributor

if we are concerned with 24h, we can start the default at 1h and then allow customers to increase it.

Personally I think 24h is okay :)

@vvcephei vvcephei changed the title test: add idle timeout feat: add idle timeout May 20, 2021
@vvcephei vvcephei merged commit db35b98 into master May 20, 2021
@agavra agavra deleted the add-idle-timeout branch May 24, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants