fix: idempotent terminate that can handle hung streams #4643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcrfxia
approved these changes
Feb 26, 2020
Fixes a couple issues with terminate: - don't throw if the query doesn't get into NOT_RUNNING state. This can happen when streams threads are stuck pending shutdown. - make terminate idempotent
rodesai
force-pushed
the
dont-fail-terminate-on-pending-close
branch
from
91c9bcb to
4603b9c
Compare
agavra
pushed a commit
that referenced
this pull request
Feb 27, 2020
Fixes a couple issues with terminate: - don't throw if the query doesn't get into NOT_RUNNING state. This can happen when streams threads are stuck pending shutdown. - make terminate idempotent
colinhicks
pushed a commit
that referenced
this pull request
Feb 27, 2020
Fixes a couple issues with terminate: - don't throw if the query doesn't get into NOT_RUNNING state. This can happen when streams threads are stuck pending shutdown. - make terminate idempotent
colinhicks
pushed a commit
that referenced
this pull request
Feb 27, 2020
Fixes a couple issues with terminate: - don't throw if the query doesn't get into NOT_RUNNING state. This can happen when streams threads are stuck pending shutdown. - make terminate idempotent
agavra
pushed a commit
to agavra/ksql
that referenced
this pull request
Feb 27, 2020
…4643) Fixes a couple issues with terminate: - don't throw if the query doesn't get into NOT_RUNNING state. This can happen when streams threads are stuck pending shutdown. - make terminate idempotent
stevenpyzhang
pushed a commit
to stevenpyzhang/ksql
that referenced
this pull request
Mar 4, 2020
…4643) Fixes a couple issues with terminate: - don't throw if the query doesn't get into NOT_RUNNING state. This can happen when streams threads are stuck pending shutdown. - make terminate idempotent
stevenpyzhang
pushed a commit
to stevenpyzhang/ksql
that referenced
this pull request
Mar 4, 2020
…4643) Fixes a couple issues with terminate: - don't throw if the query doesn't get into NOT_RUNNING state. This can happen when streams threads are stuck pending shutdown. - make terminate idempotent
stevenpyzhang
added a commit
that referenced
this pull request
Mar 6, 2020
* fix: idempotent terminate that can handle hung streams (#4643) Fixes a couple issues with terminate: - don't throw if the query doesn't get into NOT_RUNNING state. This can happen when streams threads are stuck pending shutdown. - make terminate idempotent * fix: don't cleanup topics on engine close (#4658) Co-authored-by: Rohan <[email protected]> Co-authored-by: Andy Coates <[email protected]> Co-authored-by: Rohan <[email protected]> Co-authored-by: Almog Gavra <[email protected]> Co-authored-by: Andy Coates <[email protected]>
2 tasks
stevenpyzhang
pushed a commit
to stevenpyzhang/ksql
that referenced
this pull request
Mar 18, 2020
…4643) Fixes a couple issues with terminate: - don't throw if the query doesn't get into NOT_RUNNING state. This can happen when streams threads are stuck pending shutdown. - make terminate idempotent
2 tasks
stevenpyzhang
added a commit
that referenced
this pull request
Mar 20, 2020
* fix: idempotent terminate that can handle hung streams (#4643) Fixes a couple issues with terminate: - don't throw if the query doesn't get into NOT_RUNNING state. This can happen when streams threads are stuck pending shutdown. - make terminate idempotent * fix: don't cleanup topics on engine close (#4658) Co-authored-by: Rohan <[email protected]> Co-authored-by: Andy Coates <[email protected]> Co-authored-by: Rohan <[email protected]> Co-authored-by: Almog Gavra <[email protected]> Co-authored-by: Andy Coates <[email protected]>
2 tasks
This was referenced Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a couple issues with terminate:
happen when streams threads are stuck pending shutdown.