Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: api config validation tweak (MINOR) #4600

Merged
merged 2 commits into from
Feb 27, 2020
Merged

chore: api config validation tweak (MINOR) #4600

merged 2 commits into from
Feb 27, 2020

Conversation

big-andy-coates
Copy link
Contributor

Description

@purplefox, quick tweak to show that you can move the validation into the config class itself.

Testing done

unit tests added.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@big-andy-coates
chore: api config validation tweak
0808dc8 
move the validation of the client auth config into the config class.
@big-andy-coates big-andy-coates requested a review from a team as a code owner February 20, 2020 12:58
purplefox
purplefox approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@purplefox purplefox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@big-andy-coates big-andy-coates merged commit e0cd731 into confluentinc:master Feb 27, 2020
@big-andy-coates big-andy-coates deleted the api_config branch February 27, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purplefox purplefox purplefox approved these changes

Assignees

@purplefox purplefox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@big-andy-coates @purplefox