feat: log groupby errors to processing logger #4575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
big-andy-coates
approved these changes
Feb 18, 2020
Comment on lines
+102
to
+110
| logger.error( | ||
| EngineProcessingLogMessageFactory.recordProcessingError( | ||
| String.format( | ||
| "Group-by column with index %d resolved to null." | ||
| + " The source row will be excluded from the table.", | ||
| index), | ||
| row | ||
| ) | ||
| ); |
There was a problem hiding this comment.
Do we want to remove the LOG.error line below now that we have this? Seems unnecessary to log the error twice.
Other uses of the processing logger don't double log.
Comment on lines
+116
to
+123
| logger.error( | ||
| EngineProcessingLogMessageFactory.recordProcessingError( | ||
| String.format( | ||
| "Error calculating group-by column with index %d. " | ||
| + "The source row will be excluded from the table: %s", | ||
| index, e.getMessage()), | ||
| e, | ||
| row | ||
| ) | ||
| ); |
There was a problem hiding this comment.
Same again - remove the LOG.error below. - and you can remove the LOG field too.
rodesai
force-pushed
the
add-processing-logger-group-by-mapper
branch
from
05cd480 to
df3b95e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Logs errors in groupby to the processing logger.
Testing done
Added unit tests for the group by mappers to ensure they log correctly.