test: copy list to prevent ConcurrentModificationException #4554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcrfxia
changed the title
vcrfxia
approved these changes
Feb 13, 2020
There was a problem hiding this comment.
Thanks @purplefox ! LGTM, though I've updated the PR title to reflect that this is a test-only change (so it won't show up in our auto-generated changelog as a bug fix).
vcrfxia
pushed a commit
to vcrfxia/ksql
that referenced
this pull request
Feb 14, 2020
2 tasks
vcrfxia
added a commit
that referenced
this pull request
Feb 17, 2020
…#4554)" (#4570) Co-authored-by: Tim Fox <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Should fix CME in test as internal list is exposed outside synchronization
Testing done
Reviewer checklist