docs: Bring KLIP-15 up to date #4499
Conversation
| @@ -89,8 +93,6 @@ operation (newlines have been added here for the sake of clarity but the real JS | |||
| ```` | |||
There was a problem hiding this comment.
Not part of the review changes, but above:
(newlines have been added here for the sake of clarity but the real JSON must not contain newlines)
we might want to clarify "real JSON must not contain unescaped newlines"
purplefox
force-pushed
the
klip15-updates
branch
from
bfac08d to
185a28d
Compare
| @@ -133,14 +132,14 @@ Push queries can be explicitly terminated by the client by making a request to t | |||
|
|
|||
| The request method will be a POST. | |||
|
|
|||
| Requests will be made to a specific URL, e.g. "/query-terminate" (this can be configurable) | |||
| Requests will be made to a specific URL, e.g. "/query-close" (this can be configurable) | |||
There was a problem hiding this comment.
It's close-query and not query-close, right?
Also, what does "(this can be configurable)" mean?
|
|
||
| All ack responses also contain a field `seq` with a 64 bit signed integer value. This number | ||
| corresponds to the sequence of the insert on the request. The first send has sequence `0`, the second | ||
| `1`, the third `3`, etc. It allows the client to correlate the ack to the corresponding send. |
There was a problem hiding this comment.
Should this be "the third 2" instead of "the third 3", because of the 0-indexing?
| In case of error, an error response (see below) will be sent. For an error response for a send, the | ||
| `seq` field will also be included. | ||
|
|
||
| Please note that acks can be returned in a different sequence to which the inserts were submitted. |
There was a problem hiding this comment.
Do we guarantee the order of the inserts, even if the order of the acks are not guaranteed, or is the order of the inserts not guaranteed either? Is this because of a limitation of the streaming protocol or something else?
There was a problem hiding this comment.
Nvm, found the answer in discussion on the original PR: #4069 (comment)
Description
Update KLIP to bring up to date wrt current development and latest PR comments
Testing done
N/A
Reviewer checklist