feat: better error message when transaction to command topic fails to initialize by timeout #4486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #4453
Moved
transactionalProducer.initTransactions()
out of the same try catch block as the rest of the transaction operations.Added more specific error message. (added as a pluggable one for scenarios where it doesn't make sense to advise the user to set their Kafka configs)
This isn't ideal currently as there are other reasons for a TimeoutException to be returned from
initTransaction
but until https://issues.apache.org/jira/browse/KAFKA-9511 is worked on, I think this is the best we can do.Testing done
Unit test
Spun up a Kafka without setting the required configs, got the error message when issuing a DDL to the server.
Reviewer checklist