fix: support WindowStart() and WindowEnd() in pull queries #4435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes: confluentinc#4015 At present `WindowStart()` and `WindowEnd()` UDAFs are special cased. This special casing was not being applied to pull queries. This change corrects this. Consider: ```json -- setup: CREATE STREAM ALL_TWEETS (LANG STRING) WITH (kafka_topic='test_topic', value_format='JSON'); CREATE TABLE TWEET_LANG AS SELECT TIMESTAMPTOSTRING(WINDOWSTART(),'yyyy-MM-dd HH:mm:ss Z', 'UTC') AS WSTART, TIMESTAMPTOSTRING(WINDOWEND(),'yyyy-MM-dd HH:mm:ss Z', 'UTC') AS WEND, LANG, COUNT(*) AS TWEET_COUNT FROM ALL_TWEETS WINDOW TUMBLING (SIZE 1 SECOND) GROUP BY LANG; -- pull query: SELECT WSTART, WEND, LANG, TWEET_COUNT FROM TWEET_LANG WHERE ROWKEY='en'; ``` Before this change the pull query would return `null` values for `WSTART` and `WEND`, even though the data was correctly populated in the `TWEET_LANG` topic. With this change the correct values for `WSTART` and `WEND` are returned. The main fix is in `StreamAggregateBuilder`, which now applies a suitable `map` call that will apply the special processing to any pull query.
Conflicting files ksql-rest-app/src/test/java/io/confluent/ksql/rest/entity/TableRowsEntityFactoryTest.java ksql-streams/src/test/java/io/confluent/ksql/execution/streams/materialization/WindowedRowTest.java
Conflicting files ksql-execution/src/test/java/io/confluent/ksql/execution/transform/window/WindowSelectMapperTest.java ksql-rest-app/src/test/java/io/confluent/ksql/rest/entity/TableRowsEntityFactoryTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes: #4015
At present
WindowStart()andWindowEnd()UDAFs are special cased. This special casing was not being applied to pull queries. This change corrects this.Consider:
Before this change the pull query would return
nullvalues forWSTARTandWEND, even though the data was correctly populated in theTWEET_LANGtopic. With this change the correct values forWSTARTandWENDare returned.How to review
The main fix is in
StreamAggregateBuilder, which now applies a suitablemapcall that will apply the special processing to any pull query.Adding the
mapcall highlighted that the wrong key was being passed to the transformers provided in themapcall when processing windowed keys: it was passing the raw key, i.e.Struct, not theWindowed<Struct>key. Fixing this required:WindowedRowto take theWindowed<Struct>key.KsMaterializedSessionTableto use the windowed key to build the windowed row.KsMaterializedWindowTableto construct aTimeWindowand use this to build the windowed row.The rest are test changes.
Testing done
Suitable test added to QTT.
Reviewer checklist