feat: support implicit casting in UDFs #4406
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4400
fixes #3791
Description
This PR adds functionality to automagically cast parameters when calling into a user defined function.
Review Guide:
SchemaUtil#areCompatible
which now supports implicit casting to determine whether or not a sqltype and param type are compatibleUdfIndex
which now first checks the strict compatibility, and if it finds nothing will check the implicit cast compatibilitySqlToJavaVisitor
, which will perform the implicit casts when the arguments are not the exact typesTesting done
Reviewer checklist