feat: Adds lag reporting and API for use in lag aware routing as described in KLIP 12 #4392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@confluentinc It looks like @AlanConfluent just signed our Contributor License Agreement. 👍 Always at your service, clabot |
agavra
approved these changes
Jan 28, 2020
ksql-engine/src/main/java/io/confluent/ksql/util/QueryMetadata.java
Outdated
Show resolved
Hide resolved
ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/HeartbeatAgent.java
Outdated
Show resolved
Hide resolved
| if (host.equals(localHostString)) { | ||
| continue; | ||
| } | ||
| final TreeMap<Long, HeartbeatInfo> heartbeats = receivedHeartbeats.get(host); | ||
| //For previously discovered hosts, if they have not received any heartbeats, mark them dead | ||
| if (heartbeats == null || heartbeats.isEmpty()) { | ||
| hostsStatus.get(host).setHostAlive(false); | ||
| hostsStatus.put(host, new HostStatusEntity(status.getHostInfoEntity(), |
There was a problem hiding this comment.
same comment as above (and one more time below), but to make life easier we could just use computeIfPresent to make it clear that the key isn't changing
There was a problem hiding this comment.
Changed to computeIfPresent.
ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/LagReportingAgent.java
Show resolved
Hide resolved
ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/LagReportingAgent.java
Outdated
Show resolved
Hide resolved
ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/LagReportingAgent.java
Outdated
Show resolved
Hide resolved
ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/LagReportingAgent.java
Outdated
Show resolved
Hide resolved
ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/LagReportingAgent.java
Outdated
Show resolved
Hide resolved
ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/resources/LagReportingResource.java
Outdated
Show resolved
Hide resolved
ksql-rest-app/src/test/java/io/confluent/ksql/rest/server/LagReportingAgentTest.java
Outdated
Show resolved
Hide resolved
AlanConfluent
force-pushed
the
lag_reporting
branch
from
d3e4f95 to
f35a7bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This creates a Service which sends state store changelog topic lags retrieved from KafkaStreams to all of the nodes in the cluster. It also has an API which can be used by pull request logic for making routing decisions.
Testing done
Added unit tests for
LagReportingAgentwhich tests APIs. Also added a functional testLagReportingAgentFunctionalTestwhich actually sets up a two node cluster, sends lags, and verifies those reported with those read directly from Kafka.Will also do additional manual testing according to this document: #4360
Reviewer checklist