fix: floating point comparison was inexact #4372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes: confluentinc#4370 Switches the generated Java code to convert the `double` to a `String`, and then using this to build the `BigDecimal`. This results in an exact `BigDecimal` for the comparison. Without this change a `double` of `0.1` is converted to a `BigDecimal` of `0.1000000000000000055511151231257827021181583404541015625`, which is greater than `0.1`, hence the bug.
Conflicting files ksql-execution/src/test/java/io/confluent/ksql/execution/codegen/SqlToJavaVisitorTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes: #4370
Switches the generated Java code to convert the
doubleto aString, and then using this to build theBigDecimal. This results in an exactBigDecimalfor the comparison.Without this change a
doubleof0.1is converted to aBigDecimalof0.1000000000000000055511151231257827021181583404541015625, which is greater than0.1, hence the bug.Testing done
Tests added.
Reviewer checklist