fix: deadlock when closing transient push query #4297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes: confluentinc#4296 The produce side not calls `offer` in a loop, with a short timeout, to try and put the row into the blocking queue. When the consume side closes the query, e.g. on an `EOFException` if the user has closed the connection, the query first closes the queue; setting a flag the producers are checking on each loop; causing any producers to exit the loop. Then it can safely close the KS topology.
|
We may want to backport this onto 5.4.1. But I'll do that manually. |
agavra
approved these changes
Jan 13, 2020
ksql-engine/src/main/java/io/confluent/ksql/query/BlockingQueryQueue.java
Outdated
Show resolved
Hide resolved
ksql-engine/src/main/java/io/confluent/ksql/query/BlockingQueryQueue.java
Outdated
Show resolved
Hide resolved
ksql-engine/src/main/java/io/confluent/ksql/query/BlockingQueryQueue.java
Outdated
Show resolved
Hide resolved
big-andy-coates
added a commit
that referenced
this pull request
Jan 14, 2020
fixes: #4296 The produce side not calls `offer` in a loop, with a short timeout, to try and put the row into the blocking queue. When the consume side closes the query, e.g. on an `EOFException` if the user has closed the connection, the query first closes the queue; setting a flag the producers are checking on each loop; causing any producers to exit the loop. Then it can safely close the KS topology. (cherry picked from commit 6b5ce0c)
big-andy-coates
added a commit
that referenced
this pull request
Jan 14, 2020
This reverts commit ac8fb63
big-andy-coates
added a commit
to big-andy-coates/ksql
that referenced
this pull request
Jan 14, 2020
fixes: confluentinc#4296 The produce side not calls `offer` in a loop, with a short timeout, to try and put the row into the blocking queue. When the consume side closes the query, e.g. on an `EOFException` if the user has closed the connection, the query first closes the queue; setting a flag the producers are checking on each loop; causing any producers to exit the loop. Then it can safely close the KS topology. (cherry picked from commit 6b5ce0c)
big-andy-coates
added a commit
to big-andy-coates/ksql
that referenced
this pull request
Jan 14, 2020
big-andy-coates
added a commit
to big-andy-coates/ksql
that referenced
this pull request
Jan 14, 2020
fixes: confluentinc#4296 The produce side not calls `offer` in a loop, with a short timeout, to try and put the row into the blocking queue. When the consume side closes the query, e.g. on an `EOFException` if the user has closed the connection, the query first closes the queue; setting a flag the producers are checking on each loop; causing any producers to exit the loop. Then it can safely close the KS topology. (cherry picked from commit 6b5ce0c)
2 tasks
big-andy-coates
added a commit
that referenced
this pull request
Jan 26, 2020
* fix: deadlock when closing transient push query (#4297) fixes: #4296 The produce side not calls `offer` in a loop, with a short timeout, to try and put the row into the blocking queue. When the consume side closes the query, e.g. on an `EOFException` if the user has closed the connection, the query first closes the queue; setting a flag the producers are checking on each loop; causing any producers to exit the loop. Then it can safely close the KS topology. (cherry picked from commit 6b5ce0c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes: #4296
The produce side not calls
offerin a loop, with a short timeout, to try and put the row into the blocking queue. When the consume side closes the query, e.g. on anEOFExceptionif the user has closed the connection, the query first closes the queue; setting a flag the producers are checking on each loop; causing any producers to exit the loop. Then it can safely close the KS topology.Testing done
Added unit tests and manual testing
Reviewer checklist