fix: CLI commands may be terminated with semicolon+whitespace (MINOR) #4234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CLI-specific commands (including
run script
) may be optionally terminated with a semicolon. However, the KSQL CLI doesn't currently support trailing whitespace for CLI-specific commands terminated with a semicolon, which leads to confusing behavior in some of our demos, as many of them includerun script
commands terminated with semicolons and newlines. For example:(with a new line at the end) results in
since the presence of the newline causes the semicolon to fail to be stripped, and it gets attached to the end of the filename argument as a result.
This PR fixes the confusing behavior.
Testing done
Unit test + manual.
Reviewer checklist