Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove RUN SCRIPT from the server implementation (MINOR) #4116

Merged
merged 1 commit into from
Dec 11, 2019

Conversation

agavra
Copy link
Contributor

@agavra agavra commented Dec 11, 2019

BREAKING CHANGE: commands that were persisted with RUN SCRIPT will no
longer be executable

fixes #2433

Description

Removes RUN SCRIPT from the server implementation. It is still available to be used in the CLI, which will submit it as a single command.

Testing done

mvn clean install

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@agavra agavra requested a review from a team as a code owner December 11, 2019 20:53
BREAKING CHANGE: commands that were persisted with RUN SCRIPT will no
longer be executable
Copy link
Contributor

@vcrfxia vcrfxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉 love seeing the code cleanup -- thanks @agavra !

@agavra agavra merged commit 0d679c9 into confluentinc:master Dec 11, 2019
@agavra agavra deleted the remove_run_script branch December 11, 2019 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove RUN SCRIPT from KSQL syntax
2 participants