chore: update KSQL_PULL_QUERIES_ENABLE_CONFIG name (MINOR) #4059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
vcrfxia
force-pushed
the
disable-pull-config-2
branch
from
75d1608 to
c8b43ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#3778 introduced a config named
ksql.pull.queries.enablefor enabling/disabling pull queries. The config was renamed toksql.query.pull.enablein #3856 after the 5.4.x branch was cut, and has therefore introduced a breaking change between 5.4 and master. This PR updates the config name in master back to the old name (the one present on 5.4) to avoid the breaking change.Replaces #4042
Testing done
Searched for appearances of
ksql.query.pull.enable(the new name that is being reverted) and updated them.Reviewer checklist