Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: schema column order returned by websocket pull query (MINOR) #4012

Merged
merged 1 commit into from
Dec 2, 2019
Merged

fix: schema column order returned by websocket pull query (MINOR) #4012

merged 1 commit into from
Dec 2, 2019

Conversation

big-andy-coates
Copy link
Contributor

Description

The order of columns was unintentionally getting changed so that key columns can before value columns. This is incorrect. A user can choose which order the columns are returned, e.g

SELECT COUNT, ROWKEY from Foo...

Testing done

usual

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@big-andy-coates
fix: schema column order returned by websocket pull query
b6a5d43 
The order of columns was unintentionally getting changed so that key columns can before value columns. This is incorrect.  A user can choose which order the columns are returned:

```sql
SELECT COUNT, ROWKEY from Foo...
```
@big-andy-coates big-andy-coates requested a review from a team as a code owner December 2, 2019 13:31
@big-andy-coates big-andy-coates changed the title fix: schema column order returned by websocket pull query fix: schema column order returned by websocket pull query (MINOR) Dec 2, 2019
agavra
agavra approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@agavra agavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but is this a breaking change? Is there anything that we know about in control center that depends on the keys coming first?

@agavra agavra requested a review from a team December 2, 2019 17:35
@big-andy-coates
Copy link
Contributor Author

It's not a breaking change, it's a bug fix. It was returning the schema columns in an order that did not line up with:

a) what the user requested
b) what the returned data was.

I'm not aware of any requirement in C3 for ordering of columns.

@big-andy-coates big-andy-coates merged commit 85fef09 into confluentinc:master Dec 2, 2019
@big-andy-coates big-andy-coates deleted the entity_util_column_order branch December 2, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agavra agavra agavra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@big-andy-coates @agavra